Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update dependency urllib3 to v1.26.5 [SECURITY] #57

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

renovate[bot]
Copy link

@renovate renovate bot commented May 9, 2021

Mend Renovate

This PR contains the following updates:

Package Change Age Adoption Passing Confidence
urllib3 (source) ==1.25.7 -> ==1.26.5 age adoption passing confidence

GitHub Vulnerability Alerts

CVE-2020-7212

The _encode_invalid_chars function in util/url.py in the urllib3 library 1.25.2 through 1.25.7 for Python allows a denial of service (CPU consumption) because of an inefficient algorithm. The percent_encodings array contains all matches of percent encodings. It is not deduplicated. For a URL of length N, the size of percent_encodings may be up to O(N). The next step (normalize existing percent-encoded bytes) also takes up to O(N) for each step, so the total time is O(N^2). If percent_encodings were deduplicated, the time to compute _encode_invalid_chars would be O(kN), where k is at most 484 ((10+6*2)^2).

CVE-2020-26137

urllib3 before 1.25.9 allows CRLF injection if the attacker controls the HTTP request method, as demonstrated by inserting CR and LF control characters in the first argument of putrequest(). NOTE: this is similar to CVE-2020-26116.

CVE-2021-33503

Impact

When provided with a URL containing many @ characters in the authority component the authority regular expression exhibits catastrophic backtracking causing a denial of service if a URL were passed as a parameter or redirected to via an HTTP redirect.

Patches

The issue has been fixed in urllib3 v1.26.5.

References

For more information

If you have any questions or comments about this advisory:


Release Notes

urllib3/urllib3

v1.26.5

Compare Source

===================

  • Fixed deprecation warnings emitted in Python 3.10.
  • Updated vendored six library to 1.16.0.
  • Improved performance of URL parser when splitting
    the authority component.

v1.26.4

Compare Source

===================

  • Changed behavior of the default SSLContext when connecting to HTTPS proxy
    during HTTPS requests. The default SSLContext now sets check_hostname=True.

v1.26.3

Compare Source

===================

  • Fixed bytes and string comparison issue with headers (Pull #​2141)

  • Changed ProxySchemeUnknown error message to be
    more actionable if the user supplies a proxy URL without
    a scheme. (Pull #​2107)

v1.26.2

Compare Source

===================

  • Fixed an issue where wrap_socket and CERT_REQUIRED wouldn't
    be imported properly on Python 2.7.8 and earlier (Pull #​2052)

v1.26.1

Compare Source

====================

  • Deprecated the urllib3[secure] extra and the urllib3.contrib.pyopenssl module.
    Both will be removed in v2.x. See this GitHub issue <https://github.com/urllib3/urllib3/issues/2680>_
    for justification and info on how to migrate.

v1.26.0

Compare Source

===================

  • NOTE: urllib3 v2.0 will drop support for Python 2.
    Read more in the v2.0 Roadmap <https://urllib3.readthedocs.io/en/latest/v2-roadmap.html>_.

  • Added support for HTTPS proxies contacting HTTPS servers (Pull #​1923, Pull #​1806)

  • Deprecated negotiating TLSv1 and TLSv1.1 by default. Users that
    still wish to use TLS earlier than 1.2 without a deprecation warning
    should opt-in explicitly by setting ssl_version=ssl.PROTOCOL_TLSv1_1 (Pull #​2002)
    Starting in urllib3 v2.0: Connections that receive a DeprecationWarning will fail

  • Deprecated Retry options Retry.DEFAULT_METHOD_WHITELIST, Retry.DEFAULT_REDIRECT_HEADERS_BLACKLIST
    and Retry(method_whitelist=...) in favor of Retry.DEFAULT_ALLOWED_METHODS,
    Retry.DEFAULT_REMOVE_HEADERS_ON_REDIRECT, and Retry(allowed_methods=...)
    (Pull #​2000) Starting in urllib3 v2.0: Deprecated options will be removed

  • Added default User-Agent header to every request (Pull #​1750)

  • Added urllib3.util.SKIP_HEADER for skipping User-Agent, Accept-Encoding,
    and Host headers from being automatically emitted with requests (Pull #​2018)

  • Collapse transfer-encoding: chunked request data and framing into
    the same socket.send() call (Pull #​1906)

  • Send http/1.1 ALPN identifier with every TLS handshake by default (Pull #​1894)

  • Properly terminate SecureTransport connections when CA verification fails (Pull #​1977)

  • Don't emit an SNIMissingWarning when passing server_hostname=None
    to SecureTransport (Pull #​1903)

  • Disabled requesting TLSv1.2 session tickets as they weren't being used by urllib3 (Pull #​1970)

  • Suppress BrokenPipeError when writing request body after the server
    has closed the socket (Pull #​1524)

  • Wrap ssl.SSLError that can be raised from reading a socket (e.g. "bad MAC")
    into an urllib3.exceptions.SSLError (Pull #​1939)

v1.25.11

Compare Source

====================

  • Fix retry backoff time parsed from Retry-After header when given
    in the HTTP date format. The HTTP date was parsed as the local timezone
    rather than accounting for the timezone in the HTTP date (typically
    UTC) (Pull #​1932, Pull #​1935, Pull #​1938, Pull #​1949)

  • Fix issue where an error would be raised when the SSLKEYLOGFILE
    environment variable was set to the empty string. Now SSLContext.keylog_file
    is not set in this situation (Pull #​2016)

v1.25.10

Compare Source

====================

  • Added support for SSLKEYLOGFILE environment variable for
    logging TLS session keys with use with programs like
    Wireshark for decrypting captured web traffic (Pull #​1867)

  • Fixed loading of SecureTransport libraries on macOS Big Sur
    due to the new dynamic linker cache (Pull #​1905)

  • Collapse chunked request bodies data and framing into one
    call to send() to reduce the number of TCP packets by 2-4x (Pull #​1906)

  • Don't insert None into ConnectionPool if the pool
    was empty when requesting a connection (Pull #​1866)

  • Avoid hasattr call in BrotliDecoder.decompress() (Pull #​1858)

v1.25.9

Compare Source

===================

  • Added InvalidProxyConfigurationWarning which is raised when
    erroneously specifying an HTTPS proxy URL. urllib3 doesn't currently
    support connecting to HTTPS proxies but will soon be able to
    and we would like users to migrate properly without much breakage.

    See this GitHub issue <https://github.com/urllib3/urllib3/issues/1850>_
    for more information on how to fix your proxy config. (Pull #​1851)

  • Drain connection after PoolManager redirect (Pull #​1817)

  • Ensure load_verify_locations raises SSLError for all backends (Pull #​1812)

  • Rename VerifiedHTTPSConnection to HTTPSConnection (Pull #​1805)

  • Allow the CA certificate data to be passed as a string (Pull #​1804)

  • Raise ValueError if method contains control characters (Pull #​1800)

  • Add __repr__ to Timeout (Pull #​1795)

v1.25.8

Compare Source

===================

  • Drop support for EOL Python 3.4 (Pull #​1774)

  • Optimize _encode_invalid_chars (Pull #​1787)


Configuration

📅 Schedule: Branch creation - "" (UTC), Automerge - At any time (no schedule defined).

🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.

Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.

🔕 Ignore: Close this PR and you won't be reminded about this update again.


  • If you want to rebase/retry this PR, check this box

This PR has been generated by Mend Renovate. View repository job log here.

@guardrails
Copy link

guardrails bot commented May 9, 2021

All previously detected findings have been fixed. Good job! 👍🎉

We will keep this comment up-to-date as you go along and notify you of any security issues that we identify.


👉 Go to the dashboard for detailed results.

📥 Happy? Share your feedback with us.

@renovate renovate bot changed the title Update dependency urllib3 to v1.25.8 [SECURITY] Update dependency urllib3 to v1.26.5 [SECURITY] Jun 6, 2021
@renovate renovate bot force-pushed the renovate/pypi-urllib3-vulnerability branch from 5ebf399 to 6d36bc7 Compare June 6, 2021 21:52
@renovate
Copy link
Author

renovate bot commented Mar 24, 2023

Edited/Blocked Notification

Renovate will not automatically rebase this PR, because it does not recognize the last commit author and assumes somebody else may have edited the PR.

You can manually request rebase by checking the rebase/retry box above.

⚠️ Warning: custom changes will be lost.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant