Addresses Automattic#12435

lpizzinidev · Sep 16, 2022 · 62173de · 62173de
1 parent 586c86f
commit 62173de
Show file tree

Hide file tree

Showing 2 changed files with 13 additions and 1 deletion.
diff --git a/lib/document.js b/lib/document.js
@@ -1735,7 +1735,7 @@ Document.prototype.$inc = function $inc(path, val) {
     this.invalidate(path, new MongooseError.CastError('number', val, path, err));
   }
 
-  const currentValue = this.$__getValue(path);
+  const currentValue = this.$__getValue(path) || 0;
 
   this.$__setValue(path, currentValue + val);
 

diff --git a/test/document.test.js b/test/document.test.js
@@ -11864,6 +11864,18 @@ describe('document', function() {
     assert.strictEqual(doc.sub.propertyB, 'foo');
     assert.strictEqual(called, 1);
   });
+
+  it('If the field does not exist, $inc should create it and set is value to the specified one (gh-12435)', async function() {
+    const schema = new mongoose.Schema({
+      count: Number
+    });
+    const Model = db.model('IncTest', schema);
+    const doc = new Model({ });
+    await doc.save();
+    doc.$inc('count', 1);
+    await doc.save();
+    assert.strictEqual(doc.count, 1);
+  });
 });
 
 describe('Check if instance function that is supplied in schema option is availabe', function() {