feat: bitdepth option for avif/heif #4036
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thank you for the PR. The prebuilt binaries only include support for a bitdepth of 8, so you won't be able to add a unit test for this path, but you can check valid values are accepted. It looks like lots of the tests are failing as the new |
|
Oh, right! I forgot the default build only supports 8-bit output. |
mertalev
force-pushed
the
feat/avif-bitdepth
branch
from
780ba3d
to
ec59738
Compare
add validation unit tests add ushort unit test add test for valid bitdepth, make test formatting consistent consistent test wording add setting to constructor remove ushort test fix unit tests bitdepth is not a boolean
mertalev
force-pushed
the
feat/avif-bitdepth
branch
from
ec59738
to
26afdb2
Compare
|
I got the tests working locally after adding |
lovell
approved these changes
Mar 21, 2024
|
I added a guard against this property when using the prebuilt binaries via commit aa1bbcb as the failure condition could otherwise lead to a segfault. |
|
Yeah, that makes sense. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Following #4031, this PR exposes a
bitdepthsetting to allow outputting 10-bit or 12-bit AVIF/HEIF files. The default remains 8, so this doesn't change the current behavior.Fixes #4031