Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: typo error text.wrap #4028

Merged
merged 2 commits into from Mar 17, 2024
Merged

fix: typo error text.wrap #4028

merged 2 commits into from Mar 17, 2024

Conversation

yolopunk
Copy link
Contributor

fix text.wrap typo error and TypeScript type defined error
Screen Shot 2024-03-14 at 22 28 17

Copy link
Owner

@lovell lovell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the PR. I checked the VipsTextWrap docs and the value for this property should be word-char - I've left some suggestions inline.

lib/constructor.js Outdated Show resolved Hide resolved
test/types/sharp.test-d.ts Outdated Show resolved Hide resolved
lib/index.d.ts Outdated Show resolved Hide resolved
lib/index.d.ts Outdated Show resolved Hide resolved
docs/api-constructor.md Outdated Show resolved Hide resolved
@yolopunk yolopunk requested a review from lovell March 17, 2024 03:36
fix: text.wrap property should be word-char be based on libvip

Co-authored-by: Lovell Fuller <lovell@users.noreply.github.com>
@lovell lovell merged commit 8fbb1cd into lovell:main Mar 17, 2024
15 checks passed
@lovell lovell added this to the v0.33.3 milestone Mar 17, 2024
@lovell
Copy link
Owner

lovell commented Mar 17, 2024

Thank you very much for fixing this, it will be included in v0.33.3.

lovell added a commit that referenced this pull request Mar 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants