Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature to use locally downloaded libvips #3196

Merged
merged 6 commits into from Apr 24, 2022
Merged

Feature to use locally downloaded libvips #3196

merged 6 commits into from Apr 24, 2022
+16 −1

Conversation

ankurparihar
Copy link
Contributor

@ankurparihar ankurparihar commented Apr 18, 2022 •
edited

Changes include

  • Feature to install the prebuilt libvips binaries from a directory on the local filesystem
  • Installation doc update
    • Separate instructions for prebuilt sharp and libvips binaries to avoid confusion
    • Added instructions to install prebuilt libvips binaries from local filesystem directory

Closes #3188

@ankurparihar
Copy link
Contributor Author

Hi @lovell

Created this PR for #3188
Let me know in case of any issues.

Thanks

lovell
lovell requested changes Apr 21, 2022
View reviewed changes
Copy link
Owner

@lovell lovell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello, thank you very much for submitting this PR, I've left a few questions/comments inline.

docs/install.md Outdated Show resolved Hide resolved
install/libvips.js Outdated Show resolved Hide resolved
package.json Outdated Show resolved Hide resolved
@coveralls
Copy link

Coverage Status

Coverage remained the same at 100.0% when pulling e65c487 on ankurparihar:feat/local-libvips into d396a4e on lovell:main.

@lovell lovell merged commit 66a3ce5 into lovell:main Apr 24, 2022
@lovell
Copy link
Owner

lovell commented Apr 24, 2022

Thank you!

@lovell lovell added this to the v0.30.5 milestone Apr 24, 2022
@ankurparihar
Copy link
Contributor Author

Thank you for this awesome library!

@ankurparihar ankurparihar deleted the feat/local-libvips branch April 24, 2022 20:22
lovell added a commit that referenced this pull request Apr 25, 2022
@lovell
Docs: changelog and credit for #3196
ee948ac
@sync-by-unito sync-by-unito bot mentioned this pull request Jun 1, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lovell lovell lovell approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v0.30.5
Development

Successfully merging this pull request may close these issues.

Unable to install with local custom-prebuilt-binaries
3 participants
@ankurparihar @coveralls @lovell