fix rotate/extract ordering for non-90 angles #1755
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi, thanks for this. Are you able to add a unit test or two that would previously have failed. There is a linter error to deal with also. |
|
will do |
|
@lovell Does it looks good enough? |
|
Sorry, I somehow missed the update notifications for this - will take a look tomorrow - thanks again for fixing it. |
|
Thanks for fixing the linter error and adding tests. Are you able to move the copy/pasted section of code that performs the rotation into a common |
|
Thanks for this PR and for bearing with me whilst I prepared the rest of the next release. This will be in v0.23.0. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1682.
Without refactoring as noted in the issue