Ensure only props owned by EXIF Object are parsed #3292

lovell · Jul 13, 2022 · c295f06 · c295f06
1 parent 6288c7b
commit c295f06
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 1 deletion.
diff --git a/docs/changelog.md b/docs/changelog.md
@@ -30,6 +30,9 @@ Requires libvips v8.13.0
 * Ensure `trim` operation is a no-op when it would reduce an image to nothing.
   [#3223](https://github.com/lovell/sharp/issues/3223)
 
+* Ensure only properties owned by the `withMetadata` EXIF Object are parsed.
+  [#3292](https://github.com/lovell/sharp/issues/3292)
+
 ## v0.30 - *dresser*
 
 Requires libvips v8.12.2

diff --git a/src/pipeline.cc b/src/pipeline.cc
@@ -1503,7 +1503,9 @@ Napi::Value pipeline(const Napi::CallbackInfo& info) {
   Napi::Array mdStrKeys = mdStrs.GetPropertyNames();
   for (unsigned int i = 0; i < mdStrKeys.Length(); i++) {
     std::string k = sharp::AttrAsStr(mdStrKeys, i);
-    baton->withMetadataStrs.insert(std::make_pair(k, sharp::AttrAsStr(mdStrs, k)));
+    if (mdStrs.HasOwnProperty(k)) {
+      baton->withMetadataStrs.insert(std::make_pair(k, sharp::AttrAsStr(mdStrs, k)));
+    }
   }
   baton->timeoutSeconds = sharp::AttrAsUint32(options, "timeoutSeconds");
   // Format-specific