Ignore sequentialRead option for stats #3462

lovell · Nov 20, 2022 · a472aea · a472aea
1 parent 01ffa80
commit a472aea
Show file tree

Hide file tree

Showing 3 changed files with 9 additions and 0 deletions.
diff --git a/docs/changelog.md b/docs/changelog.md
@@ -15,6 +15,9 @@ Requires libvips v8.13.3
 * Improve `extractChannel` support for 16-bit output colourspaces.
   [#3453](https://github.com/lovell/sharp/issues/3453)
 
+* Ignore `sequentialRead` option when calculating image statistics.
+  [#3462](https://github.com/lovell/sharp/issues/3462)
+
 ### v0.31.2 - 4th November 2022
 
 * Upgrade to libvips v8.13.3 for upstream bug fixes.

diff --git a/src/stats.cc b/src/stats.cc
@@ -176,6 +176,7 @@ Napi::Value stats(const Napi::CallbackInfo& info) {
 
   // Input
   baton->input = sharp::CreateInputDescriptor(options.Get("input").As<Napi::Object>());
+  baton->input->access = VIPS_ACCESS_RANDOM;
 
   // Function to notify of libvips warnings
   Napi::Function debuglog = options.Get("debuglog").As<Napi::Function>();

diff --git a/test/unit/stats.js b/test/unit/stats.js
@@ -730,4 +730,9 @@ describe('Image Stats', function () {
       done();
     });
   });
+
+  it('Sequential read option is ignored', async () => {
+    const { isOpaque } = await sharp(fixtures.inputJpg, { sequentialRead: true }).stats();
+    assert.strictEqual(isOpaque, true);
+  });
 });