Fix setting WebP effort to 0 in constructor #3259

Setting WebP effort to 0 in the constructor caused effort to use the default value of 4.
lovell · Jun 15, 2022 · 717b1dc · 717b1dc
1 parent b10d8f8
commit 717b1dc
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 1 deletion.
diff --git a/lib/output.js b/lib/output.js
@@ -495,7 +495,7 @@ function webp (options) {
     if (is.defined(options.smartSubsample)) {
       this._setBooleanOption('webpSmartSubsample', options.smartSubsample);
     }
-    const effort = options.effort || options.reductionEffort;
+    const effort = is.defined(options.effort) ? options.effort : options.reductionEffort;
     if (is.defined(effort)) {
       if (is.integer(effort) && is.inRange(effort, 0, 6)) {
         this.options.webpEffort = effort;

diff --git a/test/unit/webp.js b/test/unit/webp.js
@@ -133,6 +133,12 @@ describe('WebP', function () {
     });
   });
 
+  it('should set effort to 0', () => {
+    const effort = sharp().webp({ effort: 0 }).options.webpEffort;
+
+    assert.strictEqual(effort, 0);
+  });
+
   it('invalid loop throws', () => {
     assert.throws(() => {
       sharp().webp({ loop: -1 });