Ensure close event occurs after end event #3313

lovell · Sep 20, 2022 · 70e6bb0 · 70e6bb0
1 parent 32aa3b4
commit 70e6bb0
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 2 deletions.
diff --git a/docs/changelog.md b/docs/changelog.md
@@ -6,6 +6,9 @@ Requires libvips v8.13.1
 
 ### v0.31.1 - TBD
 
+* Ensure `close` event occurs after `end` event for Stream-based output.
+  [#3313](https://github.com/lovell/sharp/issues/3313)
+
 * Ensure `limitInputPixels` constructor option uses uint64.
   [#3349](https://github.com/lovell/sharp/pull/3349)
   [@marcosc90](https://github.com/marcosc90)

diff --git a/lib/output.js b/lib/output.js
@@ -1205,7 +1205,7 @@ function _pipeline (callback) {
             this.push(data);
           }
           this.push(null);
-          this.emit('close');
+          this.on('end', () => this.emit('close'));
         });
       });
       if (this.streamInFinished) {
@@ -1221,7 +1221,7 @@ function _pipeline (callback) {
           this.push(data);
         }
         this.push(null);
-        this.emit('close');
+        this.on('end', () => this.emit('close'));
       });
     }
     return this;