fix: improve performance of getReport()

[styfle]

This will improve performance for newer versions of Node.js because this report doesn't need to access the network.

• See report: add --report-exclude-network option nodejs/node#51645

[lovell]

Thank you for the PR Steven, I hadn't seen this new feature. Is it just me or is the API we have to use to set excludeNetwork somewhat awkward?

I've made a suggestion to move the /* istanbul ignore next */ exclusion up a level to the surrounding conditional, which I think should deal with the unit test failure.

I need to fix up the integration tests first as NodeSource have totally changed the way their repos work, plus a couple of the more rolling flavours of Linux such as Fedora 39 have upgraded their version of glibc within the last few months. Leave it with me.

UPDATE: Please can you rebase against main and the integration tests should pass again.

[styfle]

Is it just me or is the API we have to use to set excludeNetwork somewhat awkward?

Agreed. Its not just excludeNetwork thats awkward, but every Report configuration: https://nodejs.org/api/report.html#configuration

[styfle]

I'm also wondering if we should update CI to run against Node.js Nightly just to confirm this doesn't cause any problems (since this feature hasn't landed on the stable channel yet)

https://nodejs.org/download/nightly/v22.0.0-nightly20240304b34512e38e/

[lovell]

Thanks for the updates. Let's wait until there's a proper, non-nightly (backported?) release of Node.js with the new flag before merging/releasing.

[lovell]

I'm going to merge this now as the change in #22 means the use of getReport() should now mostly be confined to musl-based Linux.

There are no nightly Node.js builds for musl and the upstream excludeNetwork patch isn't planned for backport, so when Node.js 22 is released we can add it to the test matrix.

[lovell]

Thanks again for the PR, this change was included in v2.0.3.