Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change supported python versions to 3.8-3.12 #263

Merged
merged 1 commit into from
May 11, 2024

Conversation

jasle
Copy link
Contributor

@jasle jasle commented May 9, 2024

Update supported python version to 3.8-3.12 and adjust checks accordingly.

@jasle jasle changed the title Changed supported python versions to 3.8-3.12 Change supported python versions to 3.8-3.12 May 9, 2024
@lovasoa
Copy link
Owner

lovasoa commented May 10, 2024

I'm ok with dropping support for python 3.6 and 3.7

Together they represent <1.5% of downloads

image

https://pypistats.org/packages/marshmallow-dataclass

But can you please bump the major version, since this is a breaking change ?

@jasle
Copy link
Contributor Author

jasle commented May 10, 2024

But can you please bump the major version, since this is a breaking change ?

Raise it to 9.0.0 right?

@lovasoa
Copy link
Owner

lovasoa commented May 10, 2024

Yes, this should be 9.0.0

@jasle jasle marked this pull request as draft May 10, 2024 22:21
@jasle jasle marked this pull request as ready for review May 10, 2024 22:23
@lovasoa lovasoa merged commit 5504913 into lovasoa:master May 11, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants