-
-
Notifications
You must be signed in to change notification settings - Fork 4.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Extend Prometheus Labels to include tags (requires restart for NEW labels on the monitor to be visible) #4704
base: master
Are you sure you want to change the base?
Conversation
I didn't had time to retest after fixing the merge conflicts... Edit(CommanderStorm):
|
ec822e6
to
78fddc7
Compare
did some basic tests and works for me as expected. After saving, the tags are immediately visible on the |
I also just did, but I cannot reproduce this working. I am missing some part. Mine is:
|
Did the same, but didn't use docker. In the repo and my PR branch |
Yes, master and all further feature development is v2.0 only.
|
Then I can't explain the difference between our both test setup's. 🤔 |
Could reproduce it after fresh config and no data. It's a feature 😉 Needs a server restart for new tag's. Edit: |
3.5 sounds fine by me.. |
Tested it again with the premise of restarting to see the monitor tags:
Looks good to me and works as intended. |
renamed PR in case title finds it's way into the changelogs, so the behaviour is noted there:
|
78fddc7
to
6c21c04
Compare
https://github.com/louislam/uptime-kuma/blob/master/CONTRIBUTING.md#can-i-create-a-pull-request-for-uptime-kuma
Tick the checkbox if you understand [x]:
Description
adds dynamic prometheus labels
fixes #680
replaces #898
Type of change
Please delete any options that are not relevant.
Checklist
Screenshots (if any)
Please do not use any external image service. Instead, just paste in or drag and drop the image here, and it will be uploaded automatically.