Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update @actions/core to stop using set-output since it is deprecated #28

Closed
OrBin opened this issue Nov 8, 2022 · 9 comments
Closed
Assignees

Comments

@OrBin
Copy link

OrBin commented Nov 8, 2022

This action uses @actions/core version 1.2.6, which is using the set-output command, that is deprectated in GitHub Action since October 11th.
@actions/core version 1.10.0 fixes this issue.

Can you please upgrade this library to keep compatibility?

@MCKevmeister
Copy link

MCKevmeister commented Jan 24, 2023

@lots0logs Any idea when this can be issue might be resolved? Otherwise, this action won't be able to be used beyond the 31 May 2023

lots0logs added a commit that referenced this issue May 17, 2023
update to node 18.
update deps.
bump version.

Part of #26 #28
@lots0logs
Copy link
Owner

@OrBin @MCKevmeister Please let me know if the latest release works okay for you. Thanks.

@lots0logs lots0logs self-assigned this May 18, 2023
@MCKevmeister
Copy link

We have backlogged a ticket and will be address this before the end of the month. Thanks for releasing an update!

@OrBin
Copy link
Author

OrBin commented May 18, 2023

Sorry @lots0logs, I do not use this action any more.

@Jeremy-NZ
Copy link

Hi @lots0logs,

it looks like you might need to upgrade some other related packages? Using the latest release I get the following error:

Prepare workflow directory
Prepare all required actions
Getting action download info
Download action repository 'actions/checkout@v3' (SHA:8e5e7e5ab8b370d6c3[29](https://github.com/genianz/genia-api/actions/runs/5020962694/jobs/9002909252#step:1:33)ec4802213[32](https://github.com/genianz/genia-api/actions/runs/5020962694/jobs/9002909252#step:1:36)ada57f0ab)
Download action repository 'actions/setup-node@v3' (SHA:64ed1c7eab4cce[33](https://github.com/genianz/genia-api/actions/runs/5020962694/jobs/9002909252#step:1:37)62f8c[34](https://github.com/genianz/genia-api/actions/runs/5020962694/jobs/9002909252#step:1:38)0dee64e5eaeef8f7c)
Download action repository 'lots0logs/gh-action-get-changed-files@2.2.0' (SHA:f11cd4567bcffc0bfd036526436e7475fa6d0418)
Error: System.ArgumentOutOfRangeException: Specified argument was out of the range of valid values. (Parameter ''using: node18' is not supported, use 'docker', 'node12' or 'node16' instead.')
   at GitHub.Runner.Worker.ActionManifestManager.ConvertRuns(IExecutionContext executionContext, TemplateContext templateContext, TemplateToken inputsToken, String fileRelativePath, MappingToken outputs)
   at GitHub.Runner.Worker.ActionManifestManager.Load(IExecutionContext executionContext, String manifestFile)
Error: Fail to load lots0logs/gh-action-get-changed-files/2.2.0/action.yml

@lots0logs
Copy link
Owner

Thanks. Fixed in 2.2.1 ✔️

@Jeremy-NZ
Copy link

Thanks @lots0logs. I just tested and that solves the node version param issue. Looks like there is another one though. I get this error now

Run lots0logs/gh-action-get-changed-files@2.2.1
/home/runner/work/_actions/lots0logs/gh-action-get-changed-files/2.2.1/dist/index.js:13100
	return gh.repos.getCommit(args);
	                ^

TypeError: Cannot read properties of undefined (reading 'getCommit')
    at fetchCommitData (/home/runner/work/_actions/lots0logs/gh-action-get-changed-files/2.2.1/dist/index.js:13100:18)
    at Array.map (<anonymous>)
    at /home/runner/work/_actions/lots0logs/gh-action-get-changed-files/2.2.1/dist/index.js:132[4](https://github.com/genianz/genia-api/actions/runs/5040035401/jobs/9038542331#step:4:5)1:22
    at processTicksAndRejections (node:internal/process/task_queues:96:[5](https://github.com/genianz/genia-api/actions/runs/5040035401/jobs/9038542331#step:4:6))

Same actions yaml works okay back on v2.1.4

lots0logs added a commit that referenced this issue May 22, 2023
@lots0logs
Copy link
Owner

@Jeremy-NZ Thanks for testing. I just released 2.2.2 which address that error.

@Jeremy-NZ
Copy link

That has done the trick. Thanks a million @lots0logs.

github-actions bot pushed a commit to GoodTimeio/action-get-changed-files that referenced this issue Mar 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants