Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace lots0logs/gh-action-get-changed-files #1847

Closed
SimenB opened this issue Feb 17, 2023 · 3 comments · Fixed by #1867
Closed

Replace lots0logs/gh-action-get-changed-files #1847

SimenB opened this issue Feb 17, 2023 · 3 comments · Fixed by #1867

Comments

@SimenB
Copy link
Member

SimenB commented Feb 17, 2023

It is unmaintained, and will stop working in May due to use of deprecated features.

- name: Calculate file differences
uses: lots0logs/gh-action-get-changed-files@2.1.4
id: diff
with:
token: ${{ secrets.GITHUB_TOKEN }}

/cc @nodejs/docker

@nschonni
Copy link
Member

Here is one approach, as they were using another action, but it often had issues with forks
https://github.com/mdn/content/blob/f8e48b90eeee2392c7bd248fa6cd802d0f84dbb8/.github/workflows/pr-check_markdownlint.yml#L17-L29

@odanado
Copy link
Contributor

odanado commented Mar 22, 2023

@SimenB @nschonni
I am interested in resolving this issue.
I think lots0logs/gh-action-get-changed-files can be replaced by https://github.com/tj-actions/changed-files.
What do you think about this strategy?

@SimenB
Copy link
Member Author

SimenB commented Mar 22, 2023

Yeah, that seems reasonable 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants