chore: rubocop lint Metrics/ClassLength #944
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Mar 13, 2019
Closed
There was a problem hiding this comment.
What value does this PR give us, and especially, our users? We're currently working on releasing Faraday v1, a finished (or at least frozen) version of what users have been relying on for years. I don't think reorganizing the code to appease Rubocop is a good idea at this stage. It doesn't actually make Faraday work any better, but it does obscure the Git history of the moved code.
I would prefer tackling these code design issues in Faraday v2. New classes and modules can be extracted in separate PRs, without the strict constraint of maintaining backwards compatibility.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
See #854 - RuboCop linting
Fixes: