Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: RuboCop lint Style/Globalvars #943

Merged
merged 3 commits into from Mar 9, 2019
Merged

chore: RuboCop lint Style/Globalvars #943

merged 3 commits into from Mar 9, 2019

Conversation

Insti
Copy link
Contributor

@Insti Insti commented Mar 9, 2019

Description

Fix for Rubocop lint Style/Globalvars
This is part of the RuboCop Quest: #854

Additional Notes

script/generate_certs is untested.

It is used by scripts/test which seems be related to adapter tests

Are these still relevant?

iMacTia
iMacTia approved these changes Mar 9, 2019
View reviewed changes
Copy link
Member

@iMacTia iMacTia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @Insti as usual for the help and don't worry about these files coverage for now.
They were the files used to trigger integration tests, but have been unused since the switch to RSpec.
We're currently discussing on what to do with files, as @technoweenie would like to reintroduce some integration tests on top of the new unit tests. So this file are hanging around until we decide on the right direction.
For now, this is one less TODO in the Rubocop quest 👍

@iMacTia
Copy link
Member

iMacTia commented Mar 9, 2019

@Insti Rubocop linting was not checked because you've probably branched out of an out-of-date master branch which doesn't include CircleCI changes. Could you please ensure you pulled the latest changes from master so we can ensure the PR is good to go 😃?

@Insti
Copy link
Contributor Author

Insti commented Mar 9, 2019

I branched from c8c9a02 which I think is the latest master?

@iMacTia iMacTia merged commit 6ff61c0 into lostisland:master Mar 9, 2019
@Insti Insti deleted the fix_style_globalvars branch March 9, 2019 13:26
@olleolleolle olleolleolle mentioned this pull request Mar 9, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@iMacTia iMacTia iMacTia approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@Insti @iMacTia