chore: Rubocop lint Style/MissingRespondToMissing #930
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The assignment to the mock connection: `Faraday.default_connection = mock_connection` was persisting throughout the tests. If the random number generator is unlucky the following error occurs: \#<Double "Connection"> was originally created in one example but has leaked into another example and can no longer be used. rspec-mocks' doubles are designed to only last for one example, and you need to create a new one in each example you wish to use it for. This commit fixes the issue by explicitly setting the default_connection back to nil in an "after" block after the tests have run. Subsequent calls to `default_connection` within the test suite then behave as previously expected irrespective of the random test ordering.
|
@Insti Would this be possible to rebase on top of |
|
Sure, is it ok if I force push? |
Closed
|
@Insti Oh, you don't have to, now. I'll Squash this on merge. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fix for Rubocop lint Style/MissingRespondToMissing
This is part of the RuboCop Quest: #854
Instead of adding a new
respond_to?method, addrespond_to_missing?which still provides the requiredrespond_to?behaviour.Additional Notes
Includes the changes from #929 that fix a test ordering dependency issue.