Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: RuboCop lint Style/MethodMissingSuper #928

Merged

Conversation

Insti
Copy link
Contributor

@Insti Insti commented Mar 4, 2019

Description

Fix for Rubocop lint Style/MethodMissingSuper
This is part of the RuboCop Quest: #854

Additional Notes

Adds unit test coverage for the Faraday#method_missing method.

Copy link
Member

@iMacTia iMacTia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for helping us out on the last efforts for this quest 😃!

@iMacTia iMacTia merged commit c5ceb26 into lostisland:master Mar 4, 2019
@olleolleolle olleolleolle mentioned this pull request Mar 4, 2019
@Insti
Copy link
Contributor Author

Insti commented Mar 4, 2019

The assignment to the mock connection

Faraday.default_connection = mock_connection

is persisting throughout the tests.

If the random number generator is unlucky the following error occurs:

       #<Double "Connection"> was originally created in one example but has leaked into another example and can no longer be used. rspec-mocks' doubles are designed to only last for one example, and you need to create a new one in each example you wish to use it for.

I'm working on a fix for this.

@Insti Insti deleted the rubocop_lint_Style/MethodMissingSuper branch March 4, 2019 22:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants