Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: RuboCop lint Metrics/BlockLength #927

Merged
merged 4 commits into from Mar 4, 2019
Merged

chore: RuboCop lint Metrics/BlockLength #927

merged 4 commits into from Mar 4, 2019

Conversation

iMacTia
Copy link
Member

@iMacTia iMacTia commented Mar 4, 2019

Description

See #854 - RuboCop linting

Fixes:

  • Metrics/BlockLength

olleolleolle
olleolleolle reviewed Mar 4, 2019
View reviewed changes
Copy link
Member

@olleolleolle olleolleolle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a gnarly piece of code - big job to make it easier to follow.

You did a great start here!

The code now is more uniform in style in decode/encode - makes it easier to follow.

lib/faraday/encoders/nested_params_encoder.rb Outdated Show resolved Hide resolved
lib/faraday/encoders/nested_params_encoder.rb Outdated Show resolved Hide resolved
@olleolleolle olleolleolle mentioned this pull request Mar 4, 2019
Closed
olleolleolle
olleolleolle approved these changes Mar 4, 2019
View reviewed changes
Copy link
Member

@olleolleolle olleolleolle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@iMacTia iMacTia merged commit 6b0eb71 into master Mar 4, 2019
@iMacTia iMacTia deleted the fix/rubocop-block-length branch March 4, 2019 21:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@olleolleolle olleolleolle olleolleolle approved these changes

@technoweenie technoweenie Awaiting requested review from technoweenie

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@iMacTia @olleolleolle