Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
See #854 - RuboCop linting
Fixes:
Additional Notes
Style/MutableConstant: I had to re-enable a disabled cop because of this RuboCop bug rubocop/rubocop#6808
Style/ModuleFunction: I had to make a
protected
functionpublic
(but it's no big deal for this particular case, IMHO) because of differences betweenextend self
andmodule_function
rubocop/ruby-style-guide#556