Chore: RuboCop Style/MultilineIfModifier #924
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Drenmi
commented
Mar 4, 2019
| @@ -44,10 +44,6 @@ class TestCase < MiniTest::Test | |||
| extend LiveServerConfig | |||
| self.live_server = ENV['LIVE'] | |||
|
|
|||
| def test_default | |||
There was a problem hiding this comment.
I couldn't find a single reference to this, and the trailing modifier can not be used to prevent method definition, so it was actually not doing anything.
|
@Drenmi Hello, and thanks for joining this Quest! Shoutout to Stockholm Ruby |
olleolleolle
approved these changes
Mar 4, 2019
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Part of RuboCop Quest.
This change fixes all instances of
MultilineIfModifier.Additional Notes
This introduces two more instances of
MethodLengthandLineLength, but since those are not addressed yet, I chose to focus on the linter at hand.