Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: RuboCop lint Style/N* #921

Merged
merged 4 commits into from Mar 3, 2019
Merged

chore: RuboCop lint Style/N* #921

merged 4 commits into from Mar 3, 2019

Conversation

iMacTia
Copy link
Member

@iMacTia iMacTia commented Mar 3, 2019

Description

See #854 - RuboCop linting

Fixes:

  • Style/NumericPredicate
  • Style/NilComparison

olleolleolle
olleolleolle approved these changes Mar 3, 2019
View reviewed changes
Copy link
Member

@olleolleolle olleolleolle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

lib/faraday/encoders/flat_params_encoder.rb Show resolved Hide resolved
@olleolleolle olleolleolle merged commit fb21e2d into master Mar 3, 2019
@olleolleolle olleolleolle deleted the fix/rubocop-style-n branch March 3, 2019 21:40
@olleolleolle olleolleolle mentioned this pull request Mar 3, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@olleolleolle olleolleolle olleolleolle approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@iMacTia @olleolleolle