chore: Fix RuboCop Style/FormatStringToken #914
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
olleolleolle
reviewed
Mar 3, 2019
.rubocop_todo.yml
Outdated
| @@ -1,6 +1,6 @@ | |||
| # This configuration was generated by | |||
| # `rubocop --auto-gen-config` | |||
| # on 2019-03-03 10:30:09 +0100 using RuboCop version 0.65.0. | |||
| # on 2019-03-03 19:25:18 +0900 using RuboCop version 0.65.0. | |||
There was a problem hiding this comment.
Ah, one of the new tricks is to revert JUST this.
Suggested change
| # on 2019-03-03 19:25:18 +0900 using RuboCop version 0.65.0. | |
| # on 2019-03-03 10:30:09 +0100 using RuboCop version 0.65.0. |
There was a problem hiding this comment.
See the #854 under Workflow.
There was a problem hiding this comment.
Thank you for your advise!
Does that mean that the time(19:25:18 +0900) has reverted?
olleolleolle
requested changes
Mar 3, 2019
| @@ -99,7 +99,8 @@ def self.decode(query) | |||
| if !last_subkey || is_array | |||
| value_type = is_array ? Array : Hash | |||
| if context[subkey] && !context[subkey].is_a?(value_type) | |||
| raise TypeError, format("expected %s (got %s) for param `%s'", value_type.name, context[subkey].class.name, subkey) | |||
| raise TypeError, format("expected %<value_type_name>s (got %<class_name>s) for param `%<subkey>s'", | |||
| value_type_name: value_type.name, class_name: context[subkey].class.name, subkey: subkey) | |||
There was a problem hiding this comment.
If this would go on more lines, each key-value pair in the hash on its own line, we could avoid adding new Metrics/LineLength issues.
There was a problem hiding this comment.
Thank you for your comments!
I try do it.
.rubocop_todo.yml
Outdated
| @@ -1,6 +1,6 @@ | |||
| # This configuration was generated by | |||
| # `rubocop --auto-gen-config` | |||
| # on 2019-03-03 10:30:09 +0100 using RuboCop version 0.65.0. | |||
| # on 2019-03-03 19:25:18 +0900 using RuboCop version 0.65.0. | |||
There was a problem hiding this comment.
See the #854 under Workflow.
htwroclau
force-pushed
the
rubocop-Style-FormatStringToken
branch
from
f673ac5
to
1058f1c
Compare
olleolleolle
approved these changes
Mar 3, 2019
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See #854 - this PR fixes Style/FormatStringToken