Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: RuboCop Style lints #898

Merged
merged 6 commits into from Feb 28, 2019
Merged

chore: RuboCop Style lints #898

merged 6 commits into from Feb 28, 2019

Conversation

iMacTia
Copy link
Member

@iMacTia iMacTia commented Feb 28, 2019

Description

See #854 - RuboCop linting

Fixes:

  • Style/YodaCondition
  • Style/UnlessElse
  • Style/TrivialAccessors
  • Style/TernaryParentheses
  • Style/SymbolProc
  • Style/SymbolArray

@olleolleolle olleolleolle mentioned this pull request Feb 28, 2019
Closed
olleolleolle
olleolleolle approved these changes Feb 28, 2019
View reviewed changes
Copy link
Member

@olleolleolle olleolleolle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Such clarity!

@olleolleolle olleolleolle merged commit 3396561 into master Feb 28, 2019
@olleolleolle olleolleolle deleted the rubocop/styles branch February 28, 2019 17:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@olleolleolle olleolleolle olleolleolle approved these changes

@technoweenie technoweenie Awaiting requested review from technoweenie

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@iMacTia @olleolleolle