Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: RuboCop Layout/DotPosition #880

Merged
merged 1 commit into from Feb 26, 2019
Merged

Conversation

jherdman
Copy link
Contributor

Description

Does what it says on the tin.

@olleolleolle
Copy link
Member

@jherdman Thanks for your tenacity!

Keep playing, the game is far from over! The Travis CI job is now more helpful, failing builds for you, and also only running one (1) job per PR.

I've had to increase the maximum class length permitted by RuboCop. In
fixing the dot position of Connection I've increased the length of said
class. Let's deal with refactoring Connection later.
@jherdman
Copy link
Contributor Author

I'm a sucker for these sorts of tasks. The very existence of the list in #854 makes my eye twitch.

Copy link
Member

@iMacTia iMacTia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @jherdman for contributing!

@iMacTia iMacTia merged commit 3adf411 into lostisland:master Feb 26, 2019
@olleolleolle olleolleolle mentioned this pull request Feb 26, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants