Resolve Layout/ElseAlignment Violations

[jherdman]

Description

Tick another box on #854

[technoweenie]

Hi @jherdman, thanks for taking a look at this! This PR doesn't actually fix all of the Layout/ElseAlignment offenses though, just the ones not excused by the rubocop todo file.

This specific change fails on master because it looks like our CI process is not preventing merges properly. This PR fixes half of it, and #870 fixes the rest. I'd like to get our CI issues resolved before merging these though.

[jherdman]

Ah, snap. I didn't realize that file was there. I'll take a look at those too.

[technoweenie]

@jherdman I'm new to rubocop, so I'm trying to come up with a general workflow. I think it's:

1. Remove exceptions from .rubocop_todo.yml
2. Fix code
3. Run bundle exec rubocop --auto-gen-config
4. Commit, PR, Merge, Profit 🤘

Do you know if there's some way to run rubocop --only=Layout/BlockEndNewline while ignoring the todo file. I'm just trying to document the rubocop fix workflow.

[jherdman]

Do you know if there's some way to run rubocop --only=Layout/BlockEndNewline while ignoring the todo file. I'm just trying to document the rubocop fix workflow

Sadly, no. I'm in the same boat as you w.r.t RuboCop.

I went back, though, and resolved the remaining ElseAlignment problems.