Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove unnecessary rubocop disable comments. #1551

Merged
merged 1 commit into from
Jan 20, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
28 changes: 14 additions & 14 deletions lib/faraday/adapter/test.rb
Original file line number Diff line number Diff line change
Expand Up @@ -99,32 +99,32 @@ def match(env)
matches?(consumed, env)
end

def get(path, headers = {}, &block) # rubocop:disable Style/ArgumentsForwarding
new_stub(:get, path, headers, &block) # rubocop:disable Style/ArgumentsForwarding
def get(path, headers = {}, &block)
new_stub(:get, path, headers, &block)
end

def head(path, headers = {}, &block) # rubocop:disable Style/ArgumentsForwarding
new_stub(:head, path, headers, &block) # rubocop:disable Style/ArgumentsForwarding
def head(path, headers = {}, &block)
new_stub(:head, path, headers, &block)
end

def post(path, body = nil, headers = {}, &block) # rubocop:disable Style/ArgumentsForwarding
new_stub(:post, path, headers, body, &block) # rubocop:disable Style/ArgumentsForwarding
def post(path, body = nil, headers = {}, &block)
new_stub(:post, path, headers, body, &block)
end

def put(path, body = nil, headers = {}, &block) # rubocop:disable Style/ArgumentsForwarding
new_stub(:put, path, headers, body, &block) # rubocop:disable Style/ArgumentsForwarding
def put(path, body = nil, headers = {}, &block)
new_stub(:put, path, headers, body, &block)
end

def patch(path, body = nil, headers = {}, &block) # rubocop:disable Style/ArgumentsForwarding
new_stub(:patch, path, headers, body, &block) # rubocop:disable Style/ArgumentsForwarding
def patch(path, body = nil, headers = {}, &block)
new_stub(:patch, path, headers, body, &block)
end

def delete(path, headers = {}, &block) # rubocop:disable Style/ArgumentsForwarding
new_stub(:delete, path, headers, &block) # rubocop:disable Style/ArgumentsForwarding
def delete(path, headers = {}, &block)
new_stub(:delete, path, headers, &block)
end

def options(path, headers = {}, &block) # rubocop:disable Style/ArgumentsForwarding
new_stub(:options, path, headers, &block) # rubocop:disable Style/ArgumentsForwarding
def options(path, headers = {}, &block)
new_stub(:options, path, headers, &block)
end

# Raises an error if any of the stubbed calls have not been made.
Expand Down
4 changes: 2 additions & 2 deletions lib/faraday/middleware_registry.rb
Original file line number Diff line number Diff line change
Expand Up @@ -59,9 +59,9 @@ def lookup_middleware(key)

private

def middleware_mutex(&block) # rubocop:disable Style/ArgumentsForwarding
def middleware_mutex(&block)
@middleware_mutex ||= Monitor.new
@middleware_mutex.synchronize(&block) # rubocop:disable Style/ArgumentsForwarding
@middleware_mutex.synchronize(&block)
end

def load_middleware(key)
Expand Down