Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: fix regex pattern in logger.md examples #1378

Merged
merged 1 commit into from Jan 11, 2022

Conversation

hirasawayuki
Copy link
Contributor

@hirasawayuki hirasawayuki commented Jan 11, 2022

Description

Fixed regex in logger.md examples 😃
Fixes #1281

Checked regular expressions in Rubular.

スクリーンショット 2022-01-11 22 49 23

スクリーンショット 2022-01-11 22 49 40

@hirasawayuki hirasawayuki changed the title docs: fix logger.md examples regex pattern docs: fix regex pattern in the logger.md examples Jan 11, 2022
@hirasawayuki hirasawayuki changed the title docs: fix regex pattern in the logger.md examples docs: fix regex pattern in logger.md examples Jan 11, 2022
Copy link
Member

@iMacTia iMacTia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Although this is not really Faraday's domain, this change makes the suggestion in the README safer and potentially helps developers building more secure apps ❤️
LGTM 💯

@iMacTia iMacTia merged commit 026e956 into lostisland:main Jan 11, 2022
@olleolleolle
Copy link
Member

Here is a link to the regular expression being used: https://rubular.com/r/jU52xDNGruN3Al

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[docs] Change regular expression used in Logger middleware example
3 participants