Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix deprecation warning #1323

Merged
merged 4 commits into from Sep 13, 2021
Merged

Fix deprecation warning #1323

merged 4 commits into from Sep 13, 2021

Conversation

iMacTia
Copy link
Member

@iMacTia iMacTia commented Sep 13, 2021

Description

Fix deprecation warning when providing basic_auth in url.
This can be tested using script/console (which was broken due to missing irb dependency in Gemfile).

# before
conn = Faraday.new('http://Aladdin:open%20sesame@sushi.com/fish')
  # WARNING: `Faraday::Connection#basic_auth` is deprecated; it will be removed in version 2.0.
  # While initializing your connection, use `#request(:basic_auth, ...)` instead.
  # See https://lostisland.github.io/faraday/middleware/authentication for more usage info.
  # => #<Faraday::Connection:0x00007fafe629f9d0

# after
conn = Faraday.new('http://Aladdin:open%20sesame@sushi.com/fish')
  # => #<Faraday::Connection:0x00007fdf352b1f30

@iMacTia iMacTia self-assigned this Sep 13, 2021
Copy link
Member

@olleolleolle olleolleolle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for fixing the warning!

@iMacTia iMacTia merged commit 18ba248 into 1.x Sep 13, 2021
@iMacTia iMacTia deleted the fix-url_prefix-deprecation-warning branch September 13, 2021 13:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants