Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use external httpclient adapter #1289

Merged
merged 1 commit into from Jul 4, 2021
Merged

Use external httpclient adapter #1289

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
1 change: 1 addition & 0 deletions faraday.gemspec
View file
Open in desktop
Expand Up @@ -18,6 +18,7 @@ Gem::Specification.new do |spec|
spec.add_dependency 'faraday-em_http', '~> 1.0'
spec.add_dependency 'faraday-em_synchrony', '~> 1.0'
spec.add_dependency 'faraday-excon', '~> 1.1'
spec.add_dependency 'faraday-httpclient', '~> 1.0.1'
spec.add_dependency 'faraday-net_http', '~> 1.0'
spec.add_dependency 'faraday-net_http_persistent', '~> 1.1'
spec.add_dependency 'multipart-post', '>= 1.2', '< 3'
Expand Down
1 change: 1 addition & 0 deletions lib/faraday.rb
View file
Open in desktop
Expand Up @@ -30,6 +30,7 @@
require 'faraday/em_http'
require 'faraday/em_synchrony'
require 'faraday/excon'
require 'faraday/httpclient'
require 'faraday/net_http'
require 'faraday/net_http_persistent'

Expand Down
3 changes: 1 addition & 2 deletions lib/faraday/adapter.rb
View file
Open in desktop
Expand Up @@ -13,8 +13,7 @@ class Adapter
test: [:Test, 'test'],
typhoeus: [:Typhoeus, 'typhoeus'],
patron: [:Patron, 'patron'],
rack: [:Rack, 'rack'],
httpclient: [:HTTPClient, 'httpclient']
rack: [:Rack, 'rack']

# This module marks an Adapter as supporting parallel requests.
module Parallelism
Expand Down
152 changes: 0 additions & 152 deletions lib/faraday/adapter/httpclient.rb
View file
Open in desktop

This file was deleted.

3 changes: 1 addition & 2 deletions lib/faraday/autoload.rb
View file
Open in desktop
Expand Up @@ -61,8 +61,7 @@ class Adapter
Typhoeus: 'typhoeus',
Patron: 'patron',
Test: 'test',
Rack: 'rack',
HTTPClient: 'httpclient'
Rack: 'rack'
end

# Request represents a single HTTP request for a Faraday adapter to make.
Expand Down