Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replacing Net::HTTP::Persistent with faraday-net_http_persistent #1250

Merged
merged 4 commits into from Mar 26, 2021
Merged

Replacing Net::HTTP::Persistent with faraday-net_http_persistent #1250

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
560f9d7
Replacing Net::HTTP::Persistent with faraday-net_http_persistent
MikeRogers0 Mar 19, 2021
be67df4
Bumping CI now v1.0.1 is out
MikeRogers0 Mar 19, 2021
fda9082
Removing net-http-persistent from Gemfile & moving it to faraday-net_…
MikeRogers0 Mar 25, 2021
12313a4
Merge branch 'master' into feature/faraday-net_http_persistent-gem
MikeRogers0 Mar 25, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
3 changes: 0 additions & 3 deletions Gemfile
View file
Open in desktop
Expand Up @@ -24,9 +24,6 @@ group :test, :development do
gem 'excon', '>= 0.27.4'
gem 'httpclient', '>= 2.2'
gem 'multipart-parser'
# TODO: remove this once v4 is released
options = (RUBY_VERSION.start_with?('3') ? { github: 'grosser/net-http-persistent', branch: 'grosser/spec' } : {})
gem 'net-http-persistent', '>= 3.0', **options
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So very nice to move this out of the way!

gem 'patron', '>= 0.4.2', platforms: :ruby
gem 'rack-test', '>= 0.6', require: 'rack/test'
gem 'rspec', '~> 3.7'
Expand Down
1 change: 1 addition & 0 deletions faraday.gemspec
View file
Open in desktop
Expand Up @@ -16,6 +16,7 @@ Gem::Specification.new do |spec|
spec.required_ruby_version = '>= 2.4'

spec.add_dependency 'faraday-net_http', '~> 1.0'
spec.add_dependency 'faraday-net_http_persistent', '~> 1.0'
spec.add_dependency 'multipart-post', '>= 1.2', '< 3'
spec.add_dependency 'ruby2_keywords', '>= 0.0.4'

Expand Down
91 changes: 0 additions & 91 deletions lib/faraday/adapter/net_http_persistent.rb
View file
Open in desktop

This file was deleted.

57 changes: 0 additions & 57 deletions spec/faraday/adapter/net_http_persistent_spec.rb
View file
Open in desktop

This file was deleted.