Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reintroduce Codeclimate coverage and badge #1233

Closed
wants to merge 1 commit into from

Conversation

olleolleolle
Copy link
Member

@olleolleolle olleolleolle commented Jan 7, 2021

Description

This reverts commit f0c76f8.

There had been fixes, codeclimate/test-reporter#413 (comment)

Fixes #1139.

Todos

  • Use the GitHub Action paambaati wrote
  • See it work
  • See if the remote side, on Codeclimate is set up correctly, it looks on that side as if it perhaps isn't, yet.

Copy link
Member

@iMacTia iMacTia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for attempting to reintroduce CodeClimate @olleolleolle!
Unfortunately, there seems to be an issue with the reporting: https://github.com/lostisland/faraday/pull/1233/checks?check_run_id=1661490696#step:8:8

Also, can I suggest to try a GitHub Action to potentially make this easier?
https://github.com/paambaati/codeclimate-action

@olleolleolle
Copy link
Member Author

Closing this in favor of #1259

@olleolleolle olleolleolle deleted the reapply-codeclimate-coverage-reporting branch April 13, 2021 16:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Wait until CodeClimate supports SimpleCov 0.18+, then re-add badge & code coverage collection
2 participants