Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds Ruby 3.0 to CI Matrix #1226

Merged
merged 5 commits into from Dec 31, 2020
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
6 changes: 1 addition & 5 deletions .github/workflows/ci.yml
Expand Up @@ -43,11 +43,7 @@ jobs:
strategy:
fail-fast: false
matrix:
ruby: ['2.4', '2.5', '2.6', '2.7']
experimental: [false]
include:
- ruby: head
experimental: true
ruby: ['2.4', '2.5', '2.6', '2.7', '3.0']

steps:
- uses: actions/checkout@v1
Expand Down
2 changes: 1 addition & 1 deletion Gemfile
Expand Up @@ -26,7 +26,7 @@ group :test, :development do
gem 'multipart-parser'
# TODO: remove this once v4 is released
options = (RUBY_VERSION.start_with?('3') ? { github: 'grosser/net-http-persistent', branch: 'grosser/spec' } : {})
gem 'net-http-persistent', (RUBY_VERSION.start_with?('3') ? '>= 3.0' : '~> 3.0'), **options
gem 'net-http-persistent', '>= 3.0', **options
gem 'patron', '>= 0.4.2', platforms: :ruby
gem 'rack-test', '>= 0.6', require: 'rack/test'
gem 'rspec', '~> 3.7'
Expand Down
2 changes: 1 addition & 1 deletion lib/faraday/adapter/net_http_persistent.rb
Expand Up @@ -51,7 +51,7 @@ def proxy_uri(env)

def perform_request(http, env)
http.request env[:url], create_request(env)
rescue Errno::ETIMEDOUT => e
rescue Errno::ETIMEDOUT, Net::OpenTimeout => e
raise Faraday::TimeoutError, e
rescue Net::HTTP::Persistent::Error => e
raise Faraday::TimeoutError, e if e.message.include? 'Timeout'
Expand Down