Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move out Net::HTTP adapter #1222

Merged
merged 3 commits into from Dec 29, 2020
Merged

Move out Net::HTTP adapter #1222

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
d33840b
Replace the Net::HTTP adapter by a separate gem
JanDintel Oct 23, 2020
11ec600
Merge master with JanDintel-replace-net-http-with-extracted-net-http-gem
iMacTia Dec 23, 2020
51cc890
Bumps faraday-net_http version to 1.0
iMacTia Dec 29, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
1 change: 1 addition & 0 deletions faraday.gemspec
View file
Open in desktop
Expand Up @@ -15,6 +15,7 @@ Gem::Specification.new do |spec|

spec.required_ruby_version = '>= 2.4'

spec.add_dependency 'faraday-net_http', '~> 0.0.6'
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hm, perhaps we should start it at 1.0?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Like, the code is what we use in this repo.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes I have already bumped faraday-net_http version to 1.0, BUT I realised @JanDintel is the only owner of the gem in Rubygems at the moment! So I can't publish it right now.
@JanDintel could you please add me and @olleolleolle as owners as well so we can publish new versions?

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@iMacTia and @olleolleolle I've added you as owners to the gem! You should have full permission to publish a new version.

@iMacTia I noticed that you still need to set-up MFA on Rubygems though :)

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@JanDintel thank you! Will release it now then, thanks a lot for all the work 🎉

@iMacTia I noticed that you still need to set-up MFA on Rubygems though :)

Yes, that's a looooooong story: rubygems/rubygems.org#2500

spec.add_dependency 'multipart-post', '>= 1.2', '< 3'
spec.add_dependency 'ruby2_keywords'

Expand Down
2 changes: 2 additions & 0 deletions lib/faraday.rb
View file
Open in desktop
Expand Up @@ -27,6 +27,8 @@
require 'faraday/file_part'
require 'faraday/param_part'

require 'faraday/net_http'

# This is the main namespace for Faraday.
#
# It provides methods to create {Connection} objects, and HTTP-related
Expand Down
1 change: 0 additions & 1 deletion lib/faraday/adapter.rb
View file
Open in desktop
Expand Up @@ -11,7 +11,6 @@ class Adapter

register_middleware File.expand_path('adapter', __dir__),
test: [:Test, 'test'],
net_http: [:NetHttp, 'net_http'],
net_http_persistent: [
:NetHttpPersistent,
'net_http_persistent'
Expand Down
220 changes: 0 additions & 220 deletions lib/faraday/adapter/net_http.rb
View file
Open in desktop

This file was deleted.

1 change: 0 additions & 1 deletion lib/faraday/autoload.rb
View file
Open in desktop
Expand Up @@ -58,7 +58,6 @@ def all_loaded_constants
class Adapter
extend AutoloadHelper
autoload_all 'faraday/adapter',
NetHttp: 'net_http',
NetHttpPersistent: 'net_http_persistent',
EMSynchrony: 'em_synchrony',
EMHttp: 'em_http',
Expand Down