Replace the Net::HTTP adapter by a separate gem #1195
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JanDintel
force-pushed
the
replace-net-http-with-extracted-net-http-gem
branch
from
937c86b
to
27af045
Compare
|
Guessing the implicit begin rescue end trio isn't available in the failing ruby version? |
JanDintel
force-pushed
the
replace-net-http-with-extracted-net-http-gem
branch
from
27af045
to
e61c942
Compare
|
@olleolleolle it was indeed the implicit begin rescue end, everything is green now. @olleolleolle and @iMacTia is this what you had in mind regarding the componentization of the adapters? |
JanDintel
force-pushed
the
replace-net-http-with-extracted-net-http-gem
branch
from
e61c942
to
2f85419
Compare
The Net::HTTP adapter is extracted into its own gem. The idea behind this change is to create an ecosystem of different packages that you can use with Faraday, so that Faraday doesn’t have to ship with the packages itself. For now all the Net::HTTP tests are still in place to verify that everything is working correctly.
JanDintel
force-pushed
the
replace-net-http-with-extracted-net-http-gem
branch
from
2f85419
to
d33840b
Compare
|
Hi @JanDintel, apologies for the late reply! |
|
Replaced by #1222 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The Net::HTTP adapter is extracted into its own gem. The idea behind this change is to create an ecosystem of different packages that you can use with Faraday, so that Faraday doesn’t have to ship with the packages itself.
For now all the Net::HTTP tests are still in place to verify that everything is working correctly.
Link to related issues if any. (As
Fixes #XXX)Todos
List any remaining work that needs to be done, i.e:
Additional Notes
Optional section