fix: Expose spec-assisting tools for authors of external adapters #1134
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
olleolleolle
changed the title
olleolleolle
changed the title
olleolleolle
changed the title
olleolleolle
changed the title
olleolleolle
changed the title
technoweenie
approved these changes
Mar 6, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This adds back the require path for "external adapters", which is an assist feature that supports adapter authors.
Details
The one such adapter in existence is faraday-http, which had a failure to build, and that led me here.
I found this out when lostisland/faraday-http#8 failed to build.
When referring to THIS PR as a dependency to that PR: we can get to green - lostisland/faraday-http#8
One thing that users of the feature may need to know is that
gem 'multipart-parser'is needed in their Gemfile.