Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FYI: Warning after upgrading this gem to 2.7.0-preview1 #989

Closed
jasnow opened this issue Jun 3, 2019 · 6 comments
Closed

FYI: Warning after upgrading this gem to 2.7.0-preview1 #989

jasnow opened this issue Jun 3, 2019 · 6 comments

Comments

@jasnow
Copy link

jasnow commented Jun 3, 2019

Basic Info

  • Faraday Version: 0.15.4
  • Ruby Version: 2.7.0-preview1

Issue description

Getting this warning after upgrading to Ruby 2.7.0-preview1:

faraday-0.15.4/lib/faraday/options.rb:166: warning: Capturing the 
given block  using Proc.new is deprecated; use `&block` instead

and

faraday-0.15.4/lib/faraday/rack_builder.rb:55: warning: Capturing the 
given block using Proc.new is deprecated; use `&block` instead

Steps to reproduce

Just upgrade a repo to Ruby 2.7.0-preview1 and then run "rake" command.
Here is a link to other repos working on this issue:

https://github.com/aws/aws-sdk-ruby/issues/2058
@iMacTia
Copy link
Member

iMacTia commented Jun 3, 2019

Hi @jasnow, thanks for raising this.
I can confirm this has already been fixed in master as of #962 👍

@iMacTia iMacTia closed this as completed Jun 3, 2019
@jasnow
Copy link
Author

jasnow commented Jun 3, 2019

I have 8 repos that use faraday gem (mostly as a sub-dependency).

@jasnow
Copy link
Author

jasnow commented Jun 10, 2019

@iMacTia - Are we close to releasing a new version of this gem?

@iMacTia
Copy link
Member

iMacTia commented Jun 10, 2019

@jasnow quite close, although next version is going to be v1.0.
Don't be too scared about the major jump though, we did our best to make it backwards-compatible to minimise disruptions. I'm sorry I can't be more precise at the moment on the exact release date, but all the maintainers are working hard to make it happen.

@jasnow
Copy link
Author

jasnow commented Jun 10, 2019

@iMacTia - Thanks for the update - I would normally just use the edge version on GitHub, but this gem is a sub-dependency for repos.

@jasnow
Copy link
Author

jasnow commented Jul 8, 2019

FYI: #993

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants