Bump faraday dependencies #5181
Conversation
|
Deploy preview for chef-inspec ready! Built with commit 36022c6 |
|
CC @rmoles for our earlier discussion |
|
Thanks @Schwad |
|
Looks like pipelines are complaining but unsure if it's faraday. What I might do is get these as green as I can, and then manually ping foundation to ensure there's no undocumented problem with touching faraday |
|
Can |
|
We're hopeful to be able to support 1.0, I'm not sure if forcing >1.0 will
cause breaking changes for someone 🤔also need to double check that it
supports ruby 2.4.
I haven't anything coming flying in from foundation-team about this pinning
so fingers crossed there are no known issues
…On Mon, Aug 10, 2020 at 11:16 AM Omer Demirok ***@***.***> wrote:
Can faraday start from version 1.0?
Some Ruby 2.7 related issues have been fixed in the major change, e.g.
lostisland/faraday#989 <lostisland/faraday#989>.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#5181 (comment)>, or
unsubscribe
<https://github.com/notifications/unsubscribe-auth/AB4AFRT2E3KVG53WWTBJMGDR77CHRANCNFSM4PUOQS6Q>
.
|
Schwad
force-pushed
the
ns/bump_faraday
branch
from
110b3f3
to
fa4d362
Compare
|
Rebuilding due to pipeline issue from last week that should hopefully be resolved |
Schwad
force-pushed
the
ns/bump_faraday
branch
from
fa4d362
to
7f3af76
Compare
|
Rebuilding this after wild (unrelated?) failures to see if we can get this merged |
There are several outstanding issues about bumping faraday and faraday_middleware. This gives us access to additional HTTP methods and the versions we are pinned to are quite old. Fixes #4234 Signed-off-by: Nick Schwaderer <nschwaderer@chef.io>
Schwad
force-pushed
the
ns/bump_faraday
branch
from
7f3af76
to
36022c6
Compare
|
This died an unceremonious death when we had hab issues. @rmoles @omerdemirok sorry for the delay I'll see if I can reignite these builds |
There are several outstanding issues about bumping faraday and
faraday_middleware. This gives us access to additional HTTP methods and
the versions we are pinned to are quite old.
Fixes #4234
This also helps us test out whether this bump passes our CI.
Signed-off-by: Nick Schwaderer nschwaderer@chef.io