Merge pull request #962 from lostisland/memoized-wo-block

Fix Memoized w/o block

lib/faraday/options.rb

@@ -171,8 +171,12 @@ def self.attribute_options
       @attribute_options ||= {}
     end
 
-    def self.memoized(key)
-      memoized_attributes[key.to_sym] = Proc.new
+    def self.memoized(key, &block)
+      unless block_given?
+        raise ArgumentError, '#memoized must be called with a block'
+      end
+
+      memoized_attributes[key.to_sym] = block
       class_eval <<-RUBY, __FILE__, __LINE__ + 1
         def #{key}() self[:#{key}]; end
       RUBY

spec/faraday/options/options_spec.rb

@@ -250,6 +250,18 @@ class ParentOptions < Faraday::Options.new(:a, :b, :c)
       end
     end
 
+    describe '#memoized' do
+      subject(:options_class) { Class.new(ParentOptions) }
+      it 'requires block' do
+        expect { options_class.memoized(:a) }.to raise_error(ArgumentError)
+      end
+
+      it 'accepts block' do
+        options_class.memoized(:a) { :foo }
+        expect(options_class.new.a).to eql(:foo)
+      end
+    end
+
     describe '#fetch' do
       subject { SubOptions.new }