Add support for custom RateLimit headers. #13
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@brookemckim 👋 Perhaps we can get to green if you rebase on top of |
iMacTia
approved these changes
Oct 12, 2022
There was a problem hiding this comment.
Thank you @brookemckim, this is a pretty cool addition 👏 !
Rubocop is complaining because the Faraday::Retry::Middleware class is too long after your recent additions ("Metrics/ClassLength: Class has too many lines. [107/105]").
You can regenerate the .rubocop_todo.yml file by running rubocop --auto-gen-config, then push the changes to that file as part of your PR 👍
|
@brookemckim Thanks for all your patience, and for improving faraday-retry! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.