-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixes compatibility issue with ruby 2.7.0 or greater #21
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for raising this!
Not really sure we're using v3 of HTTP, doesn't really make sense and v5 is almost out, so using v4 as a base totally make sense.
Just a tiny little detail from me before merging.
faraday-http.gemspec
Outdated
@@ -39,7 +39,7 @@ Gem::Specification.new do |spec| | |||
spec.executables = spec.files.grep(%r{^exe/}) { |f| File.basename(f) } | |||
spec.require_paths = ['lib'] | |||
|
|||
spec.add_dependency 'http', '~> 3.0' | |||
spec.add_dependency 'http', '~> 4' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Never used the pessimistic operator without decimals 🤔...
I know ~> 4.0
would mean >= 4.0
, <5
, but ~> 4
? Does that stop from upgrading to 5 😅?
I'd personally feel more comfortable having ~> 4.0
as I couldn't find references on how this behaves
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@iMacTia I amended the commit
Bumps http.rb dependency to version 4
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, looks good!
Preparing to merge. |
Bumps http.rb dependency to version 4
Resolves #15
Related http.rb gem issue