Add Prometheus Metrics Support #116
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| @@ -57,6 +58,15 @@ | |||
| return blockCache, apiServer, nil | |||
| } | |||
|
|
|||
| func serveMetrics(addr string) { | |||
| http.Handle("/metrics", promhttp.Handler()) | |||
| err := http.ListenAndServe(addr, nil) | |||
Check failure
Code scanning / Golang security checks by gosec
Use of net/http serve function that has no support for setting timeouts Error
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change adds support for configuring a Prometheus Server to provide metrics into both the number of domains on the block list, as well as the number of blocks/allows served by the DNS Resolver.
I wasn't able to get the Perf Benchmark running, but would expect this to have little impact since the metrics emission and logging are done in background threads.