Add missing absolute imports #453
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
donatoaguirre24
requested review from
aperezcristina,
elestu,
emmaielle,
eleleiva,
majitoven,
mconiglio,
mwolman,
rlezuez,
Rminetti,
rndelpuerto,
seedwalk,
Tiago-Zarzavidjian and
ValeFranchi
as code owners
eleleiva
reviewed
Sep 19, 2020
Rminetti
approved these changes
Sep 21, 2020
mconiglio
reviewed
Sep 21, 2020
| @@ -7,9 +7,6 @@ const authenticator = (httpClient, store) => { | |||
| if (session) { | |||
| Object.assign(config.headers, session); | |||
| } else { | |||
| // Waiting for https://github.com/axios/axios/issues/2190 | |||
| /* eslint-disable no-param-reassign */ | |||
| config.params = config.params || {}; | |||
There was a problem hiding this comment.
I have been waiting for this day 馃槀
mconiglio
approved these changes
Sep 21, 2020
Tiago-Zarzavidjian
approved these changes
Sep 22, 2020
eleleiva
approved these changes
Sep 22, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
馃搫 Description:
This PR adds all the missing absolute imports with exception of the Title since there's already an open PR to remove it.
鉁旓笍 Tasks:
v0.20.0node-sassandautoprefixer(tailwind leftovers)shallowEqual,more info on when is needed hereREADMEto reflect the new styling approach.鈴笍 Demo:
@loopstudio/react-devs