refactor: Update every operation.
#242
Conversation
drupol
force-pushed
the
misc/update-callback-reducer-signature
branch
3 times, most recently
from
5f22391
to
3c6bb94
Compare
drupol
force-pushed
the
misc/update-every-operation
branch
from
1f59d66
to
10a5693
Compare
|
Since this pull request has not had any activity within the last 5 days, I have marked it as stale. |
drupol
force-pushed
the
misc/update-every-operation
branch
4 times, most recently
from
2dccb4c
to
a65e3d0
Compare
drupol
force-pushed
the
misc/update-every-operation
branch
4 times, most recently
from
3a1501f
to
b2abd1b
Compare
src/Operation/Pluck.php
Outdated
| @@ -19,6 +19,7 @@ | |||
| use function in_array; | |||
| use function is_array; | |||
| use function is_object; | |||
| use function is_scalar; | |||
There was a problem hiding this comment.
hmm did you add this manually or was it added by php-cs-fixer or something automatically? 🤔
There was a problem hiding this comment.
cool, I guess it's not set up to import all native functions though, because there are others like array_shift and property_exists in this file that are not imported
There was a problem hiding this comment.
It has been added in here: PHP-CS-Fixer/PHP-CS-Fixer#6277
There was a problem hiding this comment.
I made a commit in master with these CS changes, so they don't pollute this branch.
There was a problem hiding this comment.
ah I see, I've typically used that rule with the all option rather than only the compiler optimized ones just for consistency, which is why I was surprised 😄
drupol
force-pushed
the
misc/update-every-operation
branch
2 times, most recently
from
1a23877
to
cbb6258
Compare
drupol
force-pushed
the
misc/update-every-operation
branch
2 times, most recently
from
e15ee2e
to
898abef
Compare
Make it more flexible and fast.
drupol
force-pushed
the
misc/update-every-operation
branch
from
898abef
to
e013ae0
Compare
Make it more flexible and fast.
This PR:
everyoperationTakeWhileandDropWhile