Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add isactive check for transaction #164

Merged
merged 1 commit into from Jan 20, 2020
Merged

feat: add isactive check for transaction #164

merged 1 commit into from Jan 20, 2020

Conversation

jannyHou
Copy link
Contributor

@jannyHou jannyHou commented Jan 20, 2020 •
edited

Break down the PR #163 into a code PR + a test PR. See the reason:

My tests fail due to a circular dependency: there is another loopback-connector installed inside node_modules in parallel with loopback-datasource-juggler and therefore loopback-datasource-juggler uses its own loopback-connector as dependency instead of my code. So I may have to release the isActive function first to get tests pass.

This is the CODE PR
test PR see #165 , we need to RELEASE the code PR first then merge the test.

Checklist

馃憠 Read and sign the CLA (Contributor License Agreement) 馃憟

  • npm test passes on your machine
  • New tests added or existing tests modified to cover all changes
  • Code conforms with the style guide
  • Commit messages are following our guidelines

This was referenced Jan 20, 2020
Merged
Closed
@jannyHou
Copy link
Contributor Author

The 3 failures are not related to this PR:

dhmlau
dhmlau approved these changes Jan 20, 2020
View reviewed changes
Copy link
Member

@dhmlau dhmlau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've reviewed this PR together with #165. They look reasonable to me, but please get at least one more reviews from others. Thanks!

@jannyHou jannyHou merged commit b294519 into master Jan 20, 2020
@delete-merged-branch delete-merged-branch bot deleted the isactive-code branch January 20, 2020 20:33
jannyHou added a commit that referenced this pull request Jan 20, 2020
@jannyHou
4.10.1
cf43a0d 
 * feat: add isactive check for transaction (#164) (Janny)
 * Remove "good first issue" from stalebot (Miroslav Bajto拧)
@jannyHou jannyHou mentioned this pull request Jan 21, 2020
Merged
7 tasks
dhmlau added a commit that referenced this pull request Mar 4, 2020
@dhmlau
4.10.2
569f966 
 * fix the way it gets column name for id property (Agnes Lin)
 * chore: update copyright year (Diana Lau)
 * test: add tests for isactive (#165) (Janny)
 * feat: add isactive check for transaction (#164) (Janny)
 * Remove "good first issue" from stalebot (Miroslav Bajto拧)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dhmlau dhmlau dhmlau approved these changes

@agnes512 agnes512 agnes512 approved these changes

@emonddr emonddr Awaiting requested review from emonddr

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@jannyHou @dhmlau @agnes512