Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Well, "fix" might overstate it, but we were able to get them passing by backporting test skips that are currently in Puma master upstream. With these skips, not only does tag `4.3.3.` all pass, but so does our custom branch, so we can be pretty confident we haven't broken anything vs. stock Puma. Some notes on test runs: - Invoke with `bundle exec rake test --trace` - Ctrl-C'ing the tests usually left a zombified version running in the background, which would *cause failures on subsequent runs*. Ensure after killing the a test run that no test processes remain in `jps -lm` - `TestThreadPool` tests are flaky in this release, though this was a known issue, and has been recently fixed here: puma#2220
- Loading branch information
1 parent
4f7ecff
commit fb2e1a9
Showing
3 changed files
with
6 additions
and
2 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters