Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: add prefix and winston logs to facebook custom audience #592

Merged
merged 4 commits into from
May 22, 2024
Merged

refactor: add prefix and winston logs to facebook custom audience #592

merged 4 commits into from
May 22, 2024

Conversation

Itzaprado
Copy link
Collaborator

Changelog:
[ ] Add Winston logs to Facebook Custom Audience action
[ ] Add Log prefix to identify the logs

@Itzaprado Itzaprado requested a review from a team as a code owner May 15, 2024 23:18
phillipperalez
phillipperalez reviewed May 16, 2024
View reviewed changes
Copy link
Collaborator

@phillipperalez phillipperalez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall good improvement, consider changing the form requests to also have the webhookId as those are generated as well

src/actions/facebook/facebook_custom_audiences.ts Show resolved Hide resolved
phillipperalez
phillipperalez requested changes May 16, 2024
View reviewed changes
Copy link
Collaborator

@phillipperalez phillipperalez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please run yarn build to check in those changes too

@Itzaprado
Copy link
Collaborator Author

please run yarn build to check in those changes too

Done

@Itzaprado Itzaprado merged commit 90f49ac into looker-open-source:master May 22, 2024
2 checks passed
@Itzaprado Itzaprado deleted the itzaprado/facebook-error-messaging branch May 22, 2024 18:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@phillipperalez phillipperalez phillipperalez approved these changes

@Jonting416 Jonting416 Awaiting requested review from Jonting416

@ehdunbar ehdunbar Awaiting requested review from ehdunbar

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@Itzaprado @phillipperalez