Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add no-store, no-cache in Cache-Control headers #373

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

Bharat23
Copy link

Changes

  • Removed the logic to never use cache if either of no-cache/no-store was present
  • Instead they work as follows
  • no-cache: doesn't use cache even if the value is present but stores the response in the cache
  • no-store: can use cache if present but will not add/update to cache
  • If both are passed, it will neither store nor use the cache. Will remove the max-age and ETag as well.
  • Test cases

Associated Issue: #144

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant