Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

#33 eslint-plugin-reactの不具合対応 #34

Merged
merged 2 commits into from Feb 27, 2022
Merged

#33 eslint-plugin-reactの不具合対応 #34

merged 2 commits into from Feb 27, 2022

Conversation

ikk2kk
Copy link
Collaborator

@ikk2kk ikk2kk commented Feb 27, 2022 •
edited

Issue番号

#33

やったこと

  • yarn.lockのeslint-plugin-reactのバージョン指定箇所を修正

    • package.jsonでeslint-plugin-react@7.28.0をインストールしてもエラーは消えなかったため、yarn.lockを修正した。

  • 上記修正をして、もう一度yarnした際、以下の依存パッケージのバージョンが下がりました。

    • minimatch
    • prop-types

  • この状態で発生していたerrorがなくなることを確認しました。

@ikk2kk ikk2kk changed the title #33 draft commit #33 eslint-plugin-reactの不具合対応 Feb 27, 2022
@ikk2kk ikk2kk requested a review from yamataso February 27, 2022 08:27
@ikk2kk ikk2kk marked this pull request as ready for review February 27, 2022 08:30
yamataso
yamataso approved these changes Feb 27, 2022
View reviewed changes
Copy link
Collaborator

@yamataso yamataso left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

問題ありません。
お疲れ様でした。

@ikk2kk ikk2kk merged commit 068705f into main Feb 27, 2022
@ikk2kk ikk2kk deleted the #33_eslint_plugin_react_downgrade branch February 27, 2022 09:00
@ikk2kk ikk2kk moved this from 進行中 to 完了 in プロジェクトの進捗管理 Feb 27, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yamataso yamataso yamataso approved these changes

Assignees

@ikk2kk ikk2kk

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@ikk2kk @yamataso